[infra] Enforce clean nightly version provenance#60
Merged
vikuznetsov-nvidia merged 1 commit intoJul 22, 2026
Merged
Conversation
Keep the nightly checkout unchanged and reject wheels whose runtime version does not identify the checked-out commit.
vikuznetsov-nvidia
requested review from
hrabeti-nvidia and
slepichev
as code owners
July 21, 2026 13:54
📝 WalkthroughWalkthroughThe nightly workflow adds Jetson ports-mirror parameters, passes mirror and clean-source settings into the C++ Docker build, removes Dockerfile patching, and supplies package version and commit information to Python wheel verification. ChangesNightly build and verification
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/nightly.yml (1)
118-118: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick winRestore the ARM64 apt mirror setup in the nightly Docker build.
UBUNTU_PORTS_MIRRORis passed toscripts/build_cuvslam_in_docker.sh, but the script never forwards it into the container, soscripts/Dockerfilestill uses the defaultports.ubuntu.comsources and DEP-11 index targets. Jetson builds can still fail on unreachable apt endpoints.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/nightly.yml at line 118, Update the nightly Docker build flow around build_cuvslam_in_docker.sh to forward UBUNTU_PORTS_MIRROR into the container, and ensure scripts/Dockerfile uses that value for ARM64 apt sources and DEP-11 index targets instead of defaulting to ports.ubuntu.com. Restore the mirror setup while preserving existing behavior for other architectures.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/workflows/nightly.yml:
- Line 118: Update the nightly Docker build flow around
build_cuvslam_in_docker.sh to forward UBUNTU_PORTS_MIRROR into the container,
and ensure scripts/Dockerfile uses that value for ARM64 apt sources and DEP-11
index targets instead of defaulting to ports.ubuntu.com. Restore the mirror
setup while preserving existing behavior for other architectures.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 61a7c49a-08e0-457f-9df0-1aaa6b05c4b0
📒 Files selected for processing (1)
.github/workflows/nightly.yml
Test Results
cuVSLAM Evaluation KPIs
Artifacts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the nightly checkout unchanged and reject wheels whose runtime version does not identify the checked-out commit.
Summary by CodeRabbit